Your message dated Mon, 31 Jul 2017 21:05:11 +0000 with message-id <e1dchsf-00009y...@fasolo.debian.org> and subject line Bug#868534: fixed in diffoscope 85 has caused the Debian Bug report #868534, regarding diffoscope: autopkgtest failure to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 868534: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=868534 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Source: diffoscope Version: 84 Severity: important Starting with version 84 a new test started to fail in autopkgtest, the one running the tests without recommends installed https://ci.debian.net/data/autopkgtest/unstable/amd64/d/diffoscope/20170715_175521/log.gz It seems to be caused by commit 037c92388ef75d5ace2d26dd85bcf7693ccf7cf6 comparators/directory: raise warning for getfacl and remove a redundant try-clause The important bit of the failure is E - --- Logging error --- E - Traceback (most recent call last): E - File "/build/diffoscope-84/diffoscope/comparators/directory.py", line 124, in compare_meta E - differences.append(Difference.from_command(Getfacl, path1, path2)) E - File "/build/diffoscope-84/diffoscope/difference.py", line 222, in from_command E - feeder1, command1 = command_and_feeder(path1) E - File "/build/diffoscope-84/diffoscope/difference.py", line 217, in command_and_feeder E - if command_excluded(command.shell_cmdline()): E - File "/build/diffoscope-84/diffoscope/comparators/utils/command.py", line 64, in shell_cmdline E - return ' '.join(map(lambda x: '{}' if x == self.path else shlex.quote(x), self.cmdline())) E - File "/build/diffoscope-84/diffoscope/tools.py", line 71, in tool_check E - raise RequiredToolNotFound(command) E - diffoscope.exc.RequiredToolNotFound: getfacl E - E - During handling of the above exception, another exception occurred: E - E - Traceback (most recent call last): E - File "/usr/lib/python3.5/logging/__init__.py", line 988, in emit E - stream.write(msg) E - ValueError: I/O operation on closed file. so my feeling is that it has to do with something like https://github.com/pytest-dev/pytest/issues/14 (but there are countless other examples on the net) needless to say, we need to workaround this somehow. -- regards, Mattia Rizzolo GPG Key: 66AE 2B4A FCCF 3F52 DA18 4D18 4B04 3FCD B944 4540 .''`. more about me: https://mapreri.org : :' : Launchpad user: https://launchpad.net/~mapreri `. `'` Debian QA page: https://qa.debian.org/developer.php?login=mattia `-
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---Source: diffoscope Source-Version: 85 We believe that the bug you reported is fixed in the latest version of diffoscope, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to 868...@bugs.debian.org, and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Mattia Rizzolo <mat...@debian.org> (supplier of updated diffoscope package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing ftpmas...@ftp-master.debian.org) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Mon, 31 Jul 2017 22:27:45 +0200 Source: diffoscope Binary: diffoscope Architecture: source Version: 85 Distribution: unstable Urgency: medium Maintainer: Reproducible builds folks <reproducible-builds@lists.alioth.debian.org> Changed-By: Mattia Rizzolo <mat...@debian.org> Description: diffoscope - in-depth comparison of files, archives, and directories Closes: 866120 868486 868534 870049 Changes: diffoscope (85) unstable; urgency=medium . [ Mattia Rizzolo ] * tools: + move from the deprecated platform.linux_distribution() to the external python package "distro". Add it as an optioanl dependency, as without it distribution detection (i.e. `diffoscope --list-tools`) won't work. Also add it as a Debian (hard) dependency, as it's a very lightway package, and the usefulness it brings are great. + add a get_package_provider() function, returning the package name that best matches the system. * exc: + in RequiredToolNotFound.get_package(), just call the new get_package_provider() * debian/rules: + recommends the defusedxml python package, to avoid using the python3's standard xml library and its security holes. . [ Chris Lamb ] * comparators: + sqlite: - Simplify file detection by rewriting manual `recognizes` call with a `Sqlite3Database.RE_FILE_TYPE` definition. + xml: - Fix EPUB "missing file" tests; they ship a META-INF/container.xml file. . [ Ximin Luo ] * comparators: + factor common logic from various comparators into File.recognizes. + more tidying up and making names consistent. + directory: - make stat(1) warning textually like the other warnings. - bump stat(1) warning into an error. - use getfacl(1) before lsattr(1) as it's more general. + apk: - less kludgy way of detecting APKs. Closes: #868486 * main, logging: + restore old logger settings to avoid pytest fail in certain situations. * debian/rules: + add a check to prevent additions of "DOS/MBR" file type. * feeder: + force a flush when writing output to diff. Closes: #870049 * tests/comparators: + directory: - be less strict about the expected test output, to cope with a missing `getfacl`. Closes: #868534 . [ Juliana Oliveira Rodrigues ] * comparators: + Add new XML comparator. Closes: #866120 The comparator will use defusedxml if this is installed, to avoid falling in known security holes coming from the XML specification. * tests/comparators: + apk: - fix the tests after the addition of the XML comparator. + image: - fix test_ico_image for identify >= 6.9.8. . [ Guangyuan Yang ] * tests/comparators: + device: - fix 2 cases for FreeBSD. Checksums-Sha1: fbf4fc1689b2b1241a3567aa972e5a4891c31c01 3228 diffoscope_85.dsc a781bde07e4705a0a3e1b2eb675905bd9a74f911 653004 diffoscope_85.tar.xz 98181b38cc107175c30e083a31d6ab6441bbde06 18385 diffoscope_85_amd64.buildinfo Checksums-Sha256: 3af990a704ba3a33ce5e3cc8ec477c1e940fa6068e8523f9c337c87206c32588 3228 diffoscope_85.dsc 2a71703db5199a6de56e21f8d1c50eea668c147e05ee06fdeda1bfd1bba27016 653004 diffoscope_85.tar.xz 7cf18e23618d2fe4efbd4995ff4803f0af51a4e45ad0051fe5381c3f1b221b28 18385 diffoscope_85_amd64.buildinfo Files: 8c6156508c5386d5f6d03621212d23dd 3228 devel optional diffoscope_85.dsc 0a6ae3525f191bff4b30b32cfc5e9b7f 653004 devel optional diffoscope_85.tar.xz e31ff3dcfd2b84502b318a43c55d263f 18385 devel optional diffoscope_85_amd64.buildinfo -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEi3hoeGwz5cZMTQpICBa54Yx2K60FAll/lV8ACgkQCBa54Yx2 K63H/w/+JwR4jI33AcYD1jxsgRho34BQ20t/F/0Eh2Y05q8sK0nh/8YxyvsmxhS4 /80ZJkNEm0bFqx378bLe18vC+wYoOTZDb4rPTQOWoxJ8NU6l4fASoXplgwYVCYo8 KDHFqWjbUH5eGYZtiT6KvIp7jHkvi5gjc29kyywZv7EC75kxqddCkQ8lzeHg5zls XrwyOpKTRMRPmxP9uZS8Z6HiYVCmYjCuCN5uvnePldtxx+Ogde4E3z8SYZWgvnRY SGyj2LnKsxvi5KIpCA6jIDwiDTiv99cdYg6G/F8nGcCBo2iHK96iyoGFmbg2t3ps 9Ru3EfFo7uou+N1G+nHUoDXoPxeB/1Y0ifrLCzrou3JFKPBFSxjiaXyhv0FAqxUF QCsvzmo4pl9RRYJ7VSfb++s4ttMwBn8Hp+LI8mhAEOkeIxLnEGUrEsF02eF6ewC5 c2v0v5OoXW2nsCfSxEVGsYZ7IKMFwH5kia3zLUvY+A/n42h+R7MiBQ3aMucs5QoM z9zxIY2LPRGP5D0VoEJ/tY45uA3Nz0hJDaKO1OTC/LyZ0AP5Qs+twVHMtqgcNmwS ijnV+DlNUI1/TLP0sfYPK1U8J4JLbxgsSv2yjiK86H7QWaXWezsDAlY/krNyU4p3 ObyZx9AAxZOiQyALNbjzcc/x7LzczVYCRkDybTtMBclSulyVubA= =pkPO -----END PGP SIGNATURE-----
--- End Message ---
_______________________________________________ Reproducible-builds mailing list Reproducible-builds@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/reproducible-builds
