John Sonnenschein wrote: > On 2-Mar-09, at 10:05 AM, Roger A. Faulkner wrote: > >> Roland Mainz wrote: [snip] > > Nit: > > Could you break the comment into more than one line, > > to make it fit in 80-columns, something like: > > > > /* > > * Allocate one extra array entry as workaround for: > > * CR 6799167 real gcc build fails in libshell > > */ > > Sorry to butt in here, but I was under the impression that code should > never make reference to the bug it fixes. Am I mistaken here?
No, you're right... but AFAIK there is an exception when you add a workaround which is expected to be removed (at least there is sufficient precedent in usr/src/uts/ for this kind of comments). IMO no _permanent_ code should contain such comments but the workarounds need such stuff (to avoid excessively large comment blocks) that there is a clear sign why it was done this way... ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL +49 641 3992797 (;O/ \/ \O;)
