Hello Yann,

I'll sponsor this one for you.

Can you send me your diffs ?
As for the (*) question, yes fix them at the same time.

Cheers
pete

Yann POUPET wrote:
> Hello,
> 
> I'd like to be sponsored for bug #618028
> http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6180248
> 
> I've had a look in the code, and as specified in the bug report, the returned 
> value of uu_msprintf() is not checked in method.c 
> (http://cvs.opensolaris.org/source/xref/on/usr/src/cmd/svc/startd/method.c , 
> line 514)
> 
> Another thing I think may be a bug, cmd, which receives the value of 
> uu_msprintf(), is not uu_free'd.(*)
> 
> There is another place where uu_msprintf()'s return value is not checked, in 
> graph.c 
> (http://cvs.opensolaris.org/source/xref/on/usr/src/cmd/svc/startd/graph.c 
> line 2074)
> 
> Last thing, in svccfg_libscf.c 
> (http://cvs.opensolaris.org/source/xref/on/usr/src/cmd/svc/svccfg/svccfg_libscf.c,
>  line 7641), str = uu_msprintf("%llu", c); five lines later, you can see 
> free(str). I think it should be uu_free(str). I don't feel this may be 
> important. (*)
> 
> (*) these are not part of the bug report, but may be corrected in the same 
> time ?
> 
> Cheers,
> 
> Yann
> This message posted from opensolaris.org
> _______________________________________________
> request-sponsor mailing list
> request-sponsor at opensolaris.org


Reply via email to