Ceri Davies wrote:
> Tony,
>
> I agree with your suggestion; I assume you don't need me to reissue the
> patch?
>
>   
No need. I'll get incorporate that into the changes.

Thanks,
tony

> Thanks again,
>
> Ceri
>
> On Mon, Oct 15, 2007 at 10:55:48AM -0700, Tony Nguyen wrote:
>   
>> Hi Ceri,
>>
>> No problem. I agree that test case in the report is sufficient. I have one 
>> nit on the change.
>>
>> Lines 336-344: For correctness, I would prefer that we replace any '.' with 
>> '_' after the last strlcat. On the other hand, we know the last strlcat 
>> wouldn't add any '.' into the string so I'm also ok with the current fix.
>>
>> Let me know you decide to do. I have a workspace built with the fix and 
>> plan to run a quick test before integration.
>>
>> Thanks,
>> -tony
>>     
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> request-sponsor mailing list
>> request-sponsor at opensolaris.org
>>     


Reply via email to