Issue 645: post-review.py: handle_renames incorrectly mangles '-->' lines  
for SVN
http://code.google.com/p/reviewboard/issues/detail?id=645

New issue report by jhartlaub:
post-review.py

1. edit an XML file in SVN containing comments like this:
<!--
-->
    remove the comments with an editor.

2. use post-review.py to post the file.

3. In the resulting review, use the "View Diffs" button.  The server
displays an error.  The error is because the diff posted by the
post-review.py script is corrupt.  The diff is corrupt because the method
"handle_renames" mangles the "-->" string and eliminates it because it is
looking indiscriminately for the string "---" in the diff.

What operating system are you using? What browser?
Windows to post, Linux to run server with Firefox.




Issue attributes:
        Status: New
        Owner: ----
        Labels: Type-Defect Priority-Medium

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to