Issue 651: There're some defect for the Windows post review process:
http://code.google.com/p/reviewboard/issues/detail?id=651

New issue report by elf1982:

1. Need to install a Perforce CLI client:
http://www.perforce.com/perforce/downloads/index.html

2. There's may be errors in the post-review.py, if there's a binary file
change(it depends on the output of 'diff'). In the attachment is a
workable script for my PC .
I modify the line 914 (if dl == [] or dl[len(dl)-1].rstrip().endswith
("differ"):)

The post-review.py works on my PC is in attachment

Attachments:
        post-review.py  53.1 KB


Issue attributes:
        Status: New
        Owner: ----
        Labels: Type-Defect Priority-Medium

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to