Issue 669: Could not change status of issue 666 - repeat of the same with  
needed info
http://code.google.com/p/reviewboard/issues/detail?id=669

New issue report by drgiri:
What's the URL of the page containing the problem?
.../r/7/diff/#index_header

What steps will reproduce the problem?
1. Generate a diff from CVS 2.0.51d
2. Post a new review request
3. Reviewer tries to view diff

What is the expected output? What do you see instead?

What i expect : To see the diff
What i get :
close_fds is not supported on Windows platforms

Traceback (most recent call last):
   File "D:\reviewboard\diffviewer\views.py", line 86, in view_diff
     files = get_diff_files(diffset, None, interdiffset, highlighting)
   File "D:\reviewboard\diffviewer\diffutils.py", line 651, in
get_diff_files
     enable_syntax_highlighting)
   File "D:\reviewboard\diffviewer\diffutils.py", line 567, in
generate_files
     lambda: get_chunks(filediff.diffset,
   File "D:\reviewboard\djblets\util\misc.py", line 55, in cache_memoize
     data = lookup_callable()
   File "D:\reviewboard\diffviewer\diffutils.py", line 570, in <lambda>
     enable_syntax_highlighting))
   File "D:\reviewboard\diffviewer\diffutils.py", line 337, in get_chunks
     old = get_original_file(filediff)
   File "D:\reviewboard\diffviewer\diffutils.py", line 244, in
get_original_file
     data = cache_memoize(key, lambda: [fetch_file(file, revision)])[0]
   File "D:\reviewboard\djblets\util\misc.py", line 55, in cache_memoize
     data = lookup_callable()
   File "D:\reviewboard\diffviewer\diffutils.py", line 244, in <lambda>
     data = cache_memoize(key, lambda: [fetch_file(file, revision)])[0]
   File "D:\reviewboard\diffviewer\diffutils.py", line 224, in fetch_file
     data = tool.get_file(file, revision)
   File "D:\reviewboard\scmtools\cvs.py", line 59, in get_file
     return self.client.cat_file(path, revision)
   File "D:\reviewboard\scmtools\cvs.py", line 163, in cat_file
     close_fds=True)
   File "C:\Python25\lib\subprocess.py", line 552, in __init__
     raise ValueError("close_fds is not supported on Windows "
ValueError: close_fds is not supported on Windows platforms


What operating system are you using? What browser?

Review board on
   Windows XP
   MySQL 5.60
Browsers used
   IE 6.0/Opera 9.5

Please provide any additional information below.



Comment 1 by chipx86, Yesterday (23 hours ago)
What version of Python are you using?
Status: NeedInfo

Comment 2 by chipx86, Yesterday (23 hours ago)
(No comment was entered for this change.)
Labels: OpSys-Windows Component-DiffViewer

Delete comment Comment 3 by drgiri, Yesterday (17 hours ago)
The following are the versions of different sw used.

Python version : Python 2.5.2
Django version 1.0
patch-2.5.9-7
PIL-1.1.6





Issue attributes:
        Status: New
        Owner: ----
        Labels: Type-Defect Priority-Medium

-- 
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to