Issue 673: Diff for text file can be lost following binary diff

New issue report by clarkd4:
*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. Prepare a P4 change that adds a binary file followed by a new text file.
Open both as text type.
2. Upload the diff.  Bytes in the binary file confuse the diff parser so it
includes the text file's contents in the binary file's diff section; the
text file is also not shown in the list of files changed.
3. Change the filetype of the binary file to ubinary and re-post the diff.
The result is unchanged.

What is the expected output? What do you see instead?

What operating system are you using? What browser?
Chrome on 2003x64; shows up in all browsers.

Please provide any additional information below.

Issue attributes:
        Status: New
        Owner: ----
        Labels: Type-Defect Priority-Medium

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at

Reply via email to