Issue 675: post-review not setting LANG variable when retrieving SVN  

New issue report by rebolledodaniel:
*NOTE: Do not post confidential information in this bug report.*

The execute function sets additional environment variables (contained in
the 'env' parameter) incorrectly.

Actual (trunk): env.update(os.environ)
Proposed:       os.environ.update(env)

The SVNClient in post-review calls "LANG=en_US.UTF-8 svn info" to retrieve
the configuration of the current repository. Setting the LANG variable is
necessary to extract the repository root in environments where english is
not the default language. Indeed, line 580 extracts the repository root
thus: m ='^Repository Root: (.+)$', data, re.M), where "data"
is the output of `svn info`. However, svn info might output "Racine du
dépôt :" instead of "Repository Root:" in non-english environments.

Setting the LANG variable is achieved through the execute function (l.1254)
which allows as second parameter a dictionary mapping new environment
variables to their desired values.

What's the URL of the page containing the problem?
line 1265

What steps will reproduce the problem?
1. Get an environment with non-english locales
2. Check out a subversion repository
3. run post-review

What is the expected output? What do you see instead?
post-review should submit the changes. Instead, The following error message

"The current directory does not contain a checkout from a
supported source code repository."

What operating system are you using? What browser?
Debian Etch

Please provide any additional information below.
My system's locale is fr_FR.UTF-8

Issue attributes:
        Status: New
        Owner: ----
        Labels: Type-Defect Priority-Medium

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at

Reply via email to