Issue 401: Comments should be inserted into diff below lines being
discussed, instead of in dialog box
Comment #4 by adam.roben:
Thanks for thinking about this.
I don't see how using a popup window fixes (1). If you try to arrange the
popup window to be below the lines
you're commenting on, then you're in the same situation you'd be in with my
proposed change. If you place
the popup window on top of the lines you're commenting on, then clearly
you're blocking the diff from view
(which is the current problem).
Why should the indicators for (2) look any different for a popup window vs.
an inline comment?
I'm not sure exactly what you mean by (3). Are you talking about the person
creating the review? Or the
person reading the review? I wasn't proposing changing the interface for
reading a review, only the interface
for creating a review. When you're creating a review, what comments
would "just appear"?
(4) seems to be explicitly talking about the interface for reading a
review, which I'm not proposing to change.
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
You received this message because you are subscribed to the Google Groups
To post to this group, send email to firstname.lastname@example.org
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at