Issue 624: Can't add inline comments from diff view "discussion" tab

Comment #3 by gmueller:
I have several comments about this workflow, which is confusing a lot of  

First, I don't think there should be a "Review" and "Discussion" tab in the  
that you get when you click on a line in the diff. That's too complicated.  
And that
"Review" link hidden next to the patch link is almost impossible to see.

The diff page should detect changes like the request page does and offer
Publish/Discard buttons at the top in the same way, and the Publish button  
bring up the equivalent of today's "Review" tab, allowing for an overall  
comment and
ticking of the "Ship It" checkbox.

Finally, it should be possible to start multiple conversations on a single  
line, and
have reply threads for each of them. And I think you should be able to add  
to those
threads without leaving the diff view.


You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at

Reply via email to