Issue 720: Editing an existing comment can change which lines it referred to

New issue report by jamesdlin:
*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. View a diff.
2. Select multiple lines in the diff and leave a comment for them.
3. Click on the first of the selected lines.  A dialog appears with the
comment from step 2.
4. Edit the comment and save changes.

What is the expected output? What do you see instead?
The comment now quotes only the first line, not all the lines selected in
step 2.

What operating system are you using? What browser?
Firefox 3.0.3 on Windows XP x64 SP2

Please provide any additional information below.
Note that this only happens when clicking on the line, not when clicking on
the comment marker in the left margin.  I suspect that this behavior is
intentional to accommodate people who want to grow or to shrink an existing
set of lines quoted in a comment.


A. When editing a comment, reviewboard could make it more obvious that the
quoted lines have changed.

B. Make a special case for the multiple-lines => 1-line scenario.

Issue attributes:
        Status: New
        Owner: ----
        Labels: Type-Defect Priority-Medium

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at

Reply via email to