Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 769 by jefflamb: post-review.py depends on diff in path variable
http://code.google.com/p/reviewboard/issues/detail?id=769

I'm using version 0.8 of post-review.py on WinXP.

The following lines gave us an issue:
return (self.do_diff('svn diff --diff-cmd=diff %s' % ' '.join(files)),
return self.do_diff('svn diff --diff-cmd=diff -r %s' % revision_range)

Maybe there's a good reason for using --diff-cmd=diff, but I don't know what
it is.  This looks for a program called diff in your path instead of using
svn's diff ability.  One developer didn't have cygwin installed and post-
review failed.

We fixed it with the following:
return (self.do_diff('svn diff %s' % ' '.join(files)),
return self.do_diff('svn diff -r %s' % revision_range)


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to