Comment #3 on issue 660 by jefflamb: RFE: Eclipse plugin for ReviewBoard http://code.google.com/p/reviewboard/issues/detail?id=660
We have the same problem. We'd love it if we could have the same integration as SVN+Eclipse (Subversive). Right now, ctrl-alt-c on a folder creates a new commit dialog for all files in and below that top-level folder. It allows you to enter descriptions and select which files you want to include in the commit. It's awesome, and could probably be duplicated nearly verbatim if you can still use post-review.py as the back-end: http://dev.eclipse.org/svnroot/technology/org.eclipse.subversive/ Here's our crude solution that works moderately well in WindowsXP. It automates the review submission, but doesn't allow you to select individual files or add descriptions/testing from eclipse. post-review.bat ~~~~~ @echo off cls SET ReviewNum="" SET ProjectsToCheck=. SET Reviewers= cd %~dp0 cd .. REM Get our list of reviewers based on who is logged in (winXP) IF NOT %USERNAME%==firstname1.lastname1 SET Reviewers=%Reviewers%firstname1.lastname1 IF NOT %USERNAME%==firstname2.lastname2 SET Reviewers=%Reviewers%firstname2.lastname2 IF NOT %USERNAME%==firstname3.lastname3 SET Reviewers=%Reviewers%firstname3.lastname3 REM This is a list of all externals we check for in a review submission IF EXIST ./external1 SET ProjectsToCheck=%ProjectsToCheck% external1 IF EXIST ./external2 SET ProjectsToCheck=%ProjectsToCheck% external2 IF EXIST ./external3 SET ProjectsToCheck=%ProjectsToCheck% external3 :needReviewNumber SET /P ReviewNum="Review Board Review Number: (press enter for new): ": IF %ReviewNum% == "" GOTO newReview IF /i %ReviewNum% leq 0 GOTO needReviewNumber IF /i %ReviewNum% geq 10000 GOTO needReviewNumber :existingReview python ./reviewboard/post-review.py %ProjectsToCheck% --target-people=%Reviewers% -o -r %ReviewNum% GOTO END :newReview python ./reviewboard/post-review.py %ProjectsToCheck% --target-people=%Reviewers% -o GOTO END :END echo Done! REM Ghetto way to get a sleep in windows xp ping 127.0.0.1 -n 4 >nul -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~----------~----~----~----~------~----~------~--~---
