Comment #2 on issue 811 by jefflamb: Discarding an update diff posts data it shouldn't http://code.google.com/p/reviewboard/issues/detail?id=811
Ok, this is exactly how I reproduce it. Check something out, make a change. Run post-review like so: post-review.py . --target-people=person1 -o It opens the page in a browser. I fill in description, testing, summary. Hit publish. Change one line in another file in the . directory. Send off an update diff: post-review.py . --target-people=person1 -o -r 123 I have "This review request is a draft." in a big green box at top with publish/discard changes buttons. At the bottom of my review, I have a "Review request changed" box, even though I didn't publish the new diff. The content of this box is blank. This also kicks off an update email to the reviewers. If I publish the changes, I correctly get another box after the empty "Review request changed" box that says: Review request changed Diff added Diff r2 -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/reviewboard-issues?hl=en -~----------~----~----~----~------~----~------~--~---
