Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 828 by mkoebele: Anchors to lines in diff viewer don't work
http://code.google.com/p/reviewboard/issues/detail?id=828

*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?
Any URL of the format
http://host/reviewboard/r/1148/diff/1/?file=26188#file26188line161

What steps will reproduce the problem?
1. go to a review and view the comments to a certain line of code in the  
diff
2. Click on the line of code which is a link with a url similar as
described above
3. The browser shows you the diff but does not scroll down to the
previously clicked line of code.

What is the expected output? What do you see instead?
I would expect that the browser scrolls down to the line of code I just
clicked on.

What operating system are you using? What browser?
firefox 2 & 3, linux and windows

Please provide any additional information below.
Not sure whether that is related...(probably not)
Under windows only and firefox 2 I get the following js error when I click
on the link to the line of code a comment was left for:

Error: [Exception... "Component is not available"  nsresult: "0x80040111
(NS_ERROR_NOT_AVAILABLE)"  location: "JS frame ::
file:///C:/PROGRA~1/MOZILL~1/components/nsSessionStore.js :: sss_saveState
:: line 1772"  data: no]
Source File: file:///C:/PROGRA~1/MOZILL~1/components/nsSessionStore.js
Line: 1772

the code it refers to is:

   /**

    * save state to disk

    * @param aUpdateAll

    *        Bool update all windows

    */

   saveState: function sss_saveState(aUpdateAll) {

     // if crash recovery is disabled, only save session resuming information

     if (!this._resume_from_crash && this._loadState == STATE_RUNNING)

       return;



     this._dirty = aUpdateAll;

     var oState = this._getCurrentState();

1772:    oState.session = { state: ((this._loadState == STATE_RUNNING) ?
STATE_RUNNING_STR : STATE_STOPPED_STR) };

     this._writeFile(this._sessionFile, oState.toSource());

     this._lastSaveTime = Date.now();

   },



--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to