Comment #3 on issue 820 by chipx86: It is possible for a user to create  
multiple draft reviews, leading to an unviewable review
http://code.google.com/p/reviewboard/issues/detail?id=820

So we're trying to be smart by setting up an asynchronous chain for the  
saves, so
that we save one comment at a time, wait for it to save, and then move on  
to the
next, and finally publish at the end.

Unfortunately, we're listening for when the inlineEditor's "complete"  
signal, which
doesn't mean we've saved to the server yet. So we end up with a race  
condition where
we're pushing all comment saves *and* publishing the review at the same  
time. The
solution is to have a custom signal emitted when we know the actual data  
has been
saved to the server.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to