Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 855 by rdsr.me: diff fails if by any chance a file identical to
previous version is submitted
http://code.google.com/p/reviewboard/issues/detail?id=855
*NOTE: Do not post confidential information in this bug report.*
What's the URL of the page containing the problem?
What steps will reproduce the problem?
1. try to submit a changelist containing a file which is identical to
previous version
2.
3.
What is the expected output? What do you see instead?
Expected output should be the diffs generated for other files and no diff
for the identical file.
We see a stack strace instead.
File "/home/y/share/reviewboard/diffviewer/views.py", line 82, in view_diff
files = get_diff_files(diffset, None, interdiffset, highlighting)
File "/home/y/share/reviewboard/diffviewer/diffutils.py", line 599, in
get_diff_files
enable_syntax_highlighting)
File "/home/y/share/reviewboard/diffviewer/diffutils.py", line 518, in
generate_files
lambda: get_chunks(filediff.diffset,
File "/home/y/share/reviewboard/djblets/util/misc.py", line 51, in
cache_memoize
data = lookup_callable()
File "/home/y/share/reviewboard/diffviewer/diffutils.py", line 521, in
<lambda>
enable_syntax_highlighting))
File "/home/y/share/reviewboard/diffviewer/diffutils.py", line 322, in
get_chunks
new = get_patched_file(old, filediff)
File "/home/y/share/reviewboard/diffviewer/diffutils.py", line 238, in
get_patched_file
return patch(filediff.diff, buffer, filediff.dest_file)
File "/home/y/share/reviewboard/diffviewer/diffutils.py", line 119, in
patch
(filename, tempdir, patch_output))
What operating system are you using? What browser?
Please provide any additional information below.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---
