Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 855 by diff fails if by any chance a file identical to  
previous version is submitted

*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. try to submit a changelist containing a file which is identical to
previous version

What is the expected output? What do you see instead?
Expected output should be the diffs generated for other files and no diff
for the identical file.
We see a stack strace instead.

  File "/home/y/share/reviewboard/diffviewer/", line 82, in view_diff
     files = get_diff_files(diffset, None, interdiffset, highlighting)
   File "/home/y/share/reviewboard/diffviewer/", line 599, in
   File "/home/y/share/reviewboard/diffviewer/", line 518, in
     lambda: get_chunks(filediff.diffset,
   File "/home/y/share/reviewboard/djblets/util/", line 51, in
     data = lookup_callable()
   File "/home/y/share/reviewboard/diffviewer/", line 521, in
   File "/home/y/share/reviewboard/diffviewer/", line 322, in
     new = get_patched_file(old, filediff)
   File "/home/y/share/reviewboard/diffviewer/", line 238, in
     return patch(filediff.diff, buffer, filediff.dest_file)
   File "/home/y/share/reviewboard/diffviewer/", line 119, in  
     (filename, tempdir, patch_output))

What operating system are you using? What browser?

Please provide any additional information below.

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to