Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 899 by erichuss: Perforce error handling problem
http://code.google.com/p/reviewboard/issues/detail?id=899

I had an issue where I did not have a p4 ticket (I set the username and
password to blank in my config), and it failed in an unclear way.

The problem is that the P4Error exception API has changed.  It now takes
two arguments.  Line 102 in perforce.py needs to change.  Additionally, as
it is written now, it ignores the first line, but I do not think that is
correct.  In my case, the p4 command only printed 1 line:
'Perforce password (P4PASSWD) invalid or unset.'

I think changing that line to something like this would be helpful:

raise P4Error('P4 command failed:', error)


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to