Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 967 by repository hostname lookups are not  
really canonical

Currently, post-review relies on calls to various socket module functions
in order to figure out the canonical FQDN of a Perforce or CVS repository.
This is not a great solution as these can actually be different on
different networks.

For Perforce, at least, the host directly out of "p4 info" is a much much
better thing to use as a canonical name for the server, because it will
always be the same everywhere. (My team thinks that for older Perforce
servers this is the p4port argument when you start the server and for newer
servers this is whatever the FQDN is for the p4port argument when you start
the server.)

Looking back at the revision history for post-review in SVN, I think the
change was made to use the socket functions for Perforce since p4 info
might give you something other than the FQDN (like "perforce" instead of
""), which won't match up with what is likely recorded
as the repository path on the Review Board server. That actually points to
a larger problem, which is that the Review Board server's network, the
post-reviewer's network, and the repository itself may all have a different
canonical name for the repository.

It may be worth separating the canonical name used to figure out which
repository a review is for from the path the Review Board server uses to
connect back to that repository later. I would think it best to use
something self-reported from the repository itself (like the results from
p4 info) for the canonical name if at all possible.

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to