Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 979 by pauloneves: Postreview uploads wrong diff in windows
http://code.google.com/p/reviewboard/issues/detail?id=979


What's the URL of the page containing the problem?

It's using postreview in Sumindo with subversion and the repository-url  
option

Acessing the diff viewer
r/62/diff/#index_header

gives me and error:

FileNotFoundError: The file '/my/path\myfile.sql' (r24294) could not be
found in the repository: 'http://my/path%5Cmyfile' path not found

I belive it is because the last slash is inverted. Probably a bug that just
happens in windows.

What steps will reproduce the problem?
1. In Windows, use postreview to upload a revision using the --remove-url
option

What is the expected output? What do you see instead?

I wanted to see the diff, but I get this traceback

Traceback (most recent call last):
   File
"C:\Python25\lib\site-packages\reviewboard-1.0alpha2.dev-py2.5.egg\reviewboard\diffviewer\views.py",
line 73, in view_diff
     files = get_diff_files(diffset, None, interdiffset, highlighting)
   File
"C:\Python25\lib\site-packages\reviewboard-1.0alpha2.dev-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 662, in get_diff_files
     enable_syntax_highlighting)
   File
"C:\Python25\lib\site-packages\reviewboard-1.0alpha2.dev-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 581, in generate_files
     large_data=True)
   File
"C:\Python25\lib\site-packages\djblets-0.5alpha2.dev_20090128-py2.5.egg\djblets\util\misc.py",
line 142, in cache_memoize
     data = lookup_callable()
   File
"C:\Python25\lib\site-packages\reviewboard-1.0alpha2.dev-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 580, in <lambda>
     enable_syntax_highlighting),
   File
"C:\Python25\lib\site-packages\reviewboard-1.0alpha2.dev-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 341, in get_chunks
     old = get_original_file(filediff)
   File
"C:\Python25\lib\site-packages\reviewboard-1.0alpha2.dev-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 248, in get_original_file
     large_data=True)[0]
   File
"C:\Python25\lib\site-packages\djblets-0.5alpha2.dev_20090128-py2.5.egg\djblets\util\misc.py",
line 142, in cache_memoize
     data = lookup_callable()
   File
"C:\Python25\lib\site-packages\reviewboard-1.0alpha2.dev-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 247, in <lambda>
     data = cache_memoize(key, lambda: [fetch_file(file, revision)],
   File
"C:\Python25\lib\site-packages\reviewboard-1.0alpha2.dev-py2.5.egg\reviewboard\diffviewer\diffutils.py",
line 227, in fetch_file
     data = tool.get_file(file, revision)
   File
"C:\Python25\lib\site-packages\reviewboard-1.0alpha2.dev-py2.5.egg\reviewboard\scmtools\svn.py",
line 107, in get_file
     raise FileNotFoundError(path, revision, str(e))
FileNotFoundError: The file '/xxx\xxx' (r24294) could not be found in the
repository: 'http://subversion/svn/xxx%5Cxxx' path not found


* What operating system are you using? What browser?

windows xp and firefox 3.0


Please provide any additional information below.


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to