Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 991 by bengchuan79: post-review.py does not trim whitespace  
before comparing a string in diff
http://code.google.com/p/reviewboard/issues/detail?id=991

at line 1486, in  def diff(self, args):

             if len(dl) == 1 and \
                dl[0] == ('Files %s and %s differ'% (old_file, new_file)):

While using with Perforce, dl[0] appears to have a whitespace. This causes
the string comparison failed.

Proposed solution:
if len(dl) == 1 and \
                string.strip(dl[0]) == ('Files %s and %s differ'% (old_file,
new_file)):

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to