Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1011 by grossag: Interdiff doesn't handle mid-review reverted  
files correctly

This was repro'd on our internal VMware setup, which uses Perforce.  Not
sure if that matters.

What steps will reproduce the problem?
1. Create a changeset with a few changed files and upload it.
2. Revert one of the files and update the diff.
3. Switch to an interdiff view between the first two revisions.

What is the expected output? What do you see instead?

When I do this, the second revision of the diff shows the reverted file as
being changed back to its original version.  So it has a few "changes"
listed.  This is technically correct, but it would be more helpful to
simply display on the right pane "The file is no longer included in the
current revision of the changeset" or something like that.  That way,
readers won't see it and wonder why I changed the code and instead
understand that I just removed/reverted the file.

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to