Labels: Type-Defect Priority-Medium
New issue 1059 by max.ritter: post-review.py does not properly upload diffs
for binary files in Perforce
*NOTE: Do not post confidential information in this bug report.*
What's the URL of the page containing the problem?
It's not public.
What steps will reproduce the problem?
1. Create a Perforce changelist containing several modified binary files.
2. Run post-review.py to upload the diffs of that changelist.
What is the expected output? What do you see instead?
I expect to see diff entries for all binary files in the new review request.
Instead, I only see a diff for the first binary file.
What operating system are you using? What browser?
Windows XP, Firefox, ReviewBoard 1.0 beta 2.
Please provide any additional information below.
I tracked down and fixed the problem in post-review.py.
Actually, the first issue was a crash for the first binary file,
because a newline was missing when matching a string "Files ... differ".
The problem described above was caused by a missing newline
in the replacement string "Binary files ... differ".
The changes are in lines 1407 and 1408 in the attached file.
post-review.py 79.9 KB
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
You received this message because you are subscribed to the Google Groups
To post to this group, send email to email@example.com
To unsubscribe from this group, send email to
For more options, visit this group at