Labels: Type-Defect Priority-Medium
New issue 1071 by raghu.kb: Review Board does not handle files with ^M
characters at end of line.
Review Board does not handle files with ^M characters at end of line.
What steps will reproduce the problem?
1. The setup is a review board server using a perforce repository
2. Create a changelist that contains at least one file with ^M characters
at end of line - i.e. \r\r\n patterns at end of line.
3. Use post-review to send it to review board.
4. Attempt to view the diff. You get a traceback.
What is the expected output? What do you see instead?
There should not be any stack trace, instead I get an error:
The patch to '%s' didn't apply cleanly. The temporary files have been left
in '%s' for debugging purposes.
I have a patch for this submitted for review.
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
You received this message because you are subscribed to the Google Groups
To post to this group, send email to firstname.lastname@example.org
To unsubscribe from this group, send email to
For more options, visit this group at