Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium

New issue 1094 by jefflamb: Copy/paste source code
http://code.google.com/p/reviewboard/issues/detail?id=1094

The diff view should allow for proper copy and pasting from a browser.

A standard copy/paste of the following source code (new added function, no
existing code on the left):

     char_t *p_pos = strchr(p_str, old);
     if (new == old) {
         return;
     }
     while (p_pos != NULL) {
         *p_pos = new;
         p_pos  = strchr(p_pos + 1, old);
     }

shows up pasted as this:

  562   

     char_t *p_pos = strchr(p_str, old);

        

        563     

        

        564     

     if (new == old) {

        

        565     

         return;

        

        566     

     }

        

        567     

        

        568     

     while (p_pos != NULL) {

        

        569     

         *p_pos = new;

        

        570     

         p_pos  = strchr(p_pos + 1, old);

        

        571     

     }

You can imagine how confusing it looks when there's a diff on the left to
copy from.

If you control and click/drag (firefox), then copy/paste, it shows up as
this (just extra newlines):

     char_t *p_pos = strchr(p_str, old);

     if (new == old) {

         return;

     }

     while (p_pos != NULL) {

         *p_pos = new;

         p_pos  = strchr(p_pos + 1, old);

     }

It'd be nice to be able to more easily copy/paste from the diff view in all
browsers.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to