Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1180 by marc.bee: cvs.exe is never found on windows and it raises  
ImportError at /r/1/
http://code.google.com/p/reviewboard/issues/detail?id=1180

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
reviewboard v1.0

What's the URL of the page containing the problem?
http://any-reviewboard-server/r/new

What steps will reproduce the problem?
1. create a new review request with a cvs repository

What is the expected output? What do you see instead?
the expected page (at least one input box to give a file)

What operating system are you using? What browser?
any browser - any windows system

Please provide any additional information below.
could be easily fixed by replacing the code below:
http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/scmtoo
ls/cvs.py, line 138
replace os.environ.get('IFS', ':') by os.pathsep

explanation:
it's quite uncommon to have such variable set on windows (IFS), so instead
of putting ':', you should put ';', but from my point of view, using the
solution given above is much much better.

Thanks for this great release!

Best Regards,

Marc Bee

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to