Labels: Type-Defect Priority-Medium
New issue 1269 by fbeachler: No error message when updating a diff that's
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
What's the URL of the page containing the problem?
UI for updating DIFF in existing review
What steps will reproduce the problem?
1. open existing review, click "Update DIFF"
2. upload a malformed DIFF
3. try steps #1,#2 as many times as you want...
What is the expected output? What do you see instead?
expected: error message, as would appear when creating a new review request
actual: saving spinner appears, disappears, update-diff-dialog stays open,
NO feedback given to user
What operating system are you using? What browser?
Please provide any additional information below.
* Originally reported in
http://code.google.com/p/reviewboard/issues/detail?id=1197 - but not
correctly identified at first.
* It simply seems the upload new diff dialog doesn't know how to process an
error response when uploading new diff.
* Firebug or packet sniffer show the error response from the server when
POSTing the new diff.
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
You received this message because you are subscribed to the Google Groups
To post to this group, send email to firstname.lastname@example.org
To unsubscribe from this group, send email to
For more options, visit this group at