Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1345 by lonico: post-review does not process a *pending* Perforce  
changeset in v0.2 beta3

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
RBTools v0.2 beta3 dev

What's the URL of the page containing the problem?
post-review command line tool

What steps will reproduce the problem?
1.have a pending changeset in Perforce, with some Affected files
2.submit a review using post-review

What is the expected output? What do you see instead?
The review should be submitted.
Here is fails with:
>>> Generating diff for changenum 969273
>>> p4 describe -s 969273
Couldn't find any affected files for this change.

The same scenarios works with v0.2 beta2

What operating system are you using? What browser?


Please provide any additional information below.

I believe the problem comes from the addition of:

+                description = []

under if '*pending*'

for Support older p4d, pending changelists on 9/21.

          debug("Generating diff for changenum %s" % changenum)

-        description = execute(["p4", "describe", "-s", changenum],
-                              split_lines=True)
+        description = []

-        if '*pending*' in description[0]:
+        if changenum == "default":
              cl_is_pending = True
+        else:
+            description = execute(["p4", "describe", "-s", changenum],
+                                  split_lines=True)
+            if '*pending*' in description[0]:
+                cl_is_pending = True
+                description = []
+        v = self.p4d_version
+        if cl_is_pending and (v[1] < 2002 or (v[1] == "2002" and v[2] <  
+            # Pre-2002.2 doesn't give file list in pending changelists, so  
+            # have to get it a different way

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to