Comment #5 on issue 1348 by premek.paska: Expanding hidden lines broken by  
the 1.0.3 update
http://code.google.com/p/reviewboard/issues/detail?id=1348

There are no JS errors reported by Firebug.

The strange thing is that all Expand links within one file use the same  
HTTP request:
javascript:expandChunk('file1', '1147', '1', null, '12', this); return  
false;
.../rb/r/139/diff/1/fragment/1147/chunk/1/

javascript:expandChunk('file1', '1147', '1', null, '19', this); return  
false;
.../rb/r/139/diff/1/fragment/1147/chunk/1/

The next file:
.../rb/r/139/diff/1/fragment/1148/chunk/1/
.../rb/r/139/diff/1/fragment/1148/chunk/1/
.../rb/r/139/diff/1/fragment/1148/chunk/1/

etc.

And consequently, all responses for different links within the file are the  
same:

One of them starts with this html code:
  <tbody id="chunk0.1">

   <tr line="26">

    <th>26</th>


    <td><pre><span class="p">{</span></pre></td>
    <th>26</th>
    <td><pre><span class="p">{</span></pre></td>

   </tr>

   <tr line="27">

    <th>27</th>

...

I compared the responses and realized that they always return the first  
five lines of
the file that are already displayed (first lines of the file's diff). So  
never the
correct lines.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-issues@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to