Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1360 by TAKAHASHI.Kazuyoshi: Can not see diff when the diff was  
uploaded with parent option on post-review

What version are you running?
ReviewBoard 1.0.4, RBTools Beta2

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. "post-review --parent=topicA --summary=testA" on topicB (branch of  
2. goto the page above.

What is the expected output? What do you see instead?
expected: could see diff.
Traceback (most recent call last):
   File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0.4-
py2.4.egg/reviewboard/diffviewer/", line 153, in view_diff
     interdiffset, highlighting, True)
   File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0.4-
py2.4.egg/reviewboard/diffviewer/", line 623, in get_diff_files
162, in cache_memoize
     data = lookup_callable()
   File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0.4-
py2.4.egg/reviewboard/diffviewer/", line 622, in <lambda>
   File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0.4-
py2.4.egg/reviewboard/diffviewer/", line 345, in get_chunks
     new = get_patched_file(old, filediff)
   File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0.4-
py2.4.egg/reviewboard/diffviewer/", line 261, in  
     return patch(filediff.diff, buffer, filediff.dest_file)
   File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0.4-
py2.4.egg/reviewboard/diffviewer/", line 126, in patch
     raise Exception(_("The patch to '%s' didn't apply cleanly. The  
temporary " +
Exception: The patch to 'adm/Rakefile' didn't apply cleanly. The temporary  
files have been left in
'/tmp/reviewboard.xXkaH8' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.xXkaH8/tmpydvPxC
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file  

What operating system are you using? What browser?
OS: Cent OS 5.2
Browser: Safari 4.0.3

Please provide any additional information below.
I've added "-t" option at as below. and it works.
Here it is...

--- /usr/lib/python2.4/site-packages/ReviewBoard-1.0.4-
py2.4.egg/reviewboard/diffviewer/       2009-10-20  
19:08:10.000000000 +0900
+++ /usr/lib/python2.4/site-packages/ReviewBoard-1.0.4-
py2.4.egg/reviewboard/diffviewer/   2009-10-20 19:08:27.000000000  
@@ -104,7 +104,7 @@

      # XXX: catch exception if Popen fails?
      newfile = '%s-new' % oldfile
-    p = subprocess.Popen(['patch', '-o', newfile, oldfile],
+    p = subprocess.Popen(['patch', '-t', '-o', newfile, oldfile],
                           stdin=subprocess.PIPE, stdout=subprocess.PIPE,

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to