Labels: Component-DiffParser Milestone-Release1.5
Comment #3 on issue 1501 by chipx86: "Download diff" for changesets
containing changes to only one file are missing diff headers
This is actually a "normal" diff, not even context. These diffs don't have
headers. The submitter should really not upload these. Looks like it was
generated by p5 diff.
It's an accident that it works at all. It happened to have the special
headers we inject to display file information, so we had enough to stick
the thing in
the database, but all the content was a "normal" diff that we don't
Our parser normally wouldn't be able to deal with it, except we have those
We do strip the headers on Unified diffs as well, so I'll fix this. If it
the normal diffs, I wouldn't bother, as those are entirely unsupported and
problem would then only exist with p5.
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
You received this message because you are subscribed to the Google Groups
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
For more options, visit this group at