Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 1515 by stodge: SVN hook can include empty arguments which seems
to confuse svn diff
http://code.google.com/p/reviewboard/issues/detail?id=1515
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
1.0.5.1
What's the URL of the page containing the problem?
n/a
What steps will reproduce the problem?
I'm getting a weird error:
./rb-post-commit-hook /srv/svn/fred 11
/usr/bin/post-review --repository-url=file:///srv/svn/fred --
username=admin --password=admin -p --submit-as=mike --revision-
range=10:11 --server=http://localhost/reviews/fred --summary="refs
#1 - publish review" --description="(In [11]) refs #1 - publish
review"
Failed to execute command: ['/usr/bin/post-review', '--repository-
url=file:///srv/svn/fred', '--username=admin', '--password=admin', '-
p', '--submit-as=mike', '--revision-range=10:11', '', '', '--
server=http://localhost/reviews/fred', '--summary="refs #1 - publish
review"', '--description="(In [11]) refs #1 - publish review"', '']
Failed to execute command: ['svn', 'diff', '--diff-cmd=diff', 'file:///
srv/svn/fred/@10', 'file:///srv/svn/fred/@11', '', '', '']
['svn: Target lists to diff may not contain both working copy paths
and URLs\n']
If I type the post-review command (I used print to display what was
being executed) then it works:
/usr/bin/post-review --repository-url=file:///srv/svn/fred --
username=admin --password=admin -p --submit-as=mike --revision-
range=10:11 --server=http://localhost/reviews/fred --summary="refs
#1 - publish review" --description="(In [11]) refs #1 - publish
review"
==> Review Board Login Required
Enter username and password for Review Board at
http://localhost/reviews/fred/
Review request #13 posted.
http://localhost/reviews/fred/r/13
What is the expected output? What do you see instead?
The review should be generated.
What operating system are you using? What browser?
Fedora 12 & Firefox/Galeon.
Please provide any additional information below.
The SVN hook can sometimes include empty arguments. Empty arguments should
be filtered from the argument list. See attached patch.
Attachments:
svn-hook-postcommit-review.patch 518 bytes
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
