Comment #4 on issue 1359 by lonico: Diff fails for text file with non-ascii characters

I have a similar issue, but with post-review:

Traceback (most recent call last):
File "/u/laurentn/p4/code-review-feb22/rbtools/", line 3137, in <module>
File "/u/laurentn/p4/code-review-feb22/rbtools/", line 3117, in main
File "/u/laurentn/p4/code-review-feb22/rbtools/", line 2747, in tempt_fate
File "/u/laurentn/p4/code-review-feb22/rbtools/", line 571, in upload_diff
    review_request['id'], fields, files)
File "/u/laurentn/p4/code-review-feb22/rbtools/", line 697, in api_post
    return self.process_json(self.http_post(path, fields, files))
File "/u/laurentn/p4/code-review-feb22/rbtools/", line 672, in http_post
    content_type, body = self._encode_multipart_formdata(fields, files)
File "/u/laurentn/p4/code-review-feb22/rbtools/", line 731, in
    return content_type, content.encode('utf-8')
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 54556: ordinal
not in range(128)

Here the diffs contain Loïc (i-trema or diaeresis).

I'm not sure if we should group all these issues into a single one or track them separately. Note that I could upload the diffs in Review Board, using upload diffs,
but the name is translated to Loïc  .

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to