Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium

New issue 1540 by emil.sit: Add basic sanity checks to git repo URL mask checking

*NOTE: If you have a patch, please submit it to

What version are you running?


What's the URL of the page this enhancement relates to, if any?

Posting of a new patch.

Describe the enhancement and the motivation for it.

When adding a new git repository, you have to specify some URL mask to
allow reviewboard to access the raw files (to generate diffs).  An improper
URL mask can lead to exceptions.

As a first pass, RB should somehow check that (a gitweb) URL at least
generates some sort of gitweb-like output if you pass in some bogus hashes,
as opposed to a 404 or 500 or other server error, at the time the
repository is created.  (I suppose this should merely be advisory, since
the server in question might be offline at the time it is being added to

When there are errors, of course, the exceptions should be caught and
brought to an administrator's attention.  (I don't know what the timeout
behavior is, but that should probably be configurable too so that the RB UI
remains usable if the remote gitweb/etc server is down.)

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to