Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium

New issue 1561 by nahor.j: post-review: obscure error if the review id is invalid
http://code.google.com/p/reviewboard/issues/detail?id=1561

What version are you running?
post-review 0.8

Describe the enhancement and the motivation for it.
If one calls post-review with an invalid review id
(-r/--review-request-id), post-review fails with an obscure error:

Traceback (most recent call last):
  File "/usr/bin/post-review", line 9, in <module>
    load_entry_point('RBTools==0.2rc1', 'console_scripts', 'post-review')()
  File
"/usr/lib64/python2.6/site-packages/RBTools-0.2rc1-py2.6.egg/rbtools/postreview.py",
line 2808, in main
    submit_as=options.submit_as)
  File
"/usr/lib64/python2.6/site-packages/RBTools-0.2rc1-py2.6.egg/rbtools/postreview.py",
line 2500, in tempt_fate
    die("Error getting review request %s: %s" % (options.rid, e))
  File
"/usr/lib64/python2.6/site-packages/RBTools-0.2rc1-py2.6.egg/rbtools/postreview.py",
line 128, in __str__
    if 'err' in self.rsp:
TypeError: argument of type 'NoneType' is not iterable


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to