Comment #1 on issue 1553 by hortonlkh: patch crash in reviewboard, post-review's difflib_unified_diff() fails to handle missing newline terminated file

My suggested workaround relies on peeking the diff file by diff.startswith("--- /vobs") to determine that the diff is from clearcase and add an extra '\n' to the original file. But it breaks if I post-review from windows, as the diff file starts with "--- X:\\foo\\bar\\..." or "--- M:\\someview\\foo\\bar\\...". Is there a call
that returns the diff is from a clearcase repo?

I also found bugs on reviewboard if I post-review on a clearcase file from windows.
I'll post it on different thread with my proposed fix.

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to