Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1571 by fbeachler: Diff-Upload UI:  Base Path field too narrow
http://code.google.com/p/reviewboard/issues/detail?id=1571

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
1.0.1rc3

What's the URL of the page containing the problem?
New Review Request (step 1)/Upload Diff

What steps will reproduce the problem?
1. click "New Review Request"
2. enter a Base Path value longer than ~50 chars

What is the expected output? What do you see instead?
Expected: to see all text that was entered.  Actual: only see a small
portion of what was entered.


What operating system are you using? What browser?
Windows/Mac OS X; Firefox 3.5+/Safari 3+

Please provide any additional information below.
There are at least two ways to fix this:  hack it in CSS; or improve the
markup for a more flexible layout.

The CSS hack involves something like:
.new_review_request div table { width : 100%; }
.new_review_request div table td:first_child { width : 150px; }

:: however the hack doesn't work when there's an error in the current UI
because the error is displayed in the third column and there's no way to
target that with CSS2 (CSS3 does support this but buggy support) ::

So, the current markup for the <form> in the "Upload DIFF" UI is like:
<div class="... new_review_request ...">
...
<table>
...
<tr>
<td><!-- form field label i.e. 'Base Path' or 'Choose Repository'</td>
<td><!-- form field i.e. select, input text or file --></td>
<td><!-- blank - container for form submission errors --></td>
</tr>
...
</table>
...
</div>

I recommend giving each TD above a class i.e. col-1, col-2, col-3 and then
set the width of each column in CSS.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to