Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1577 by lonico: Comments that were entered in a section of code that is folded are not visible, even when expanding that section

*NOTE: Do not post confidential information in this bug report.*

What version are you running?
1.5 Beta1

What's the URL of the page containing the problem?

What steps will reproduce the problem?
1. Have a diffset with at least 2 files
2. Expand a section in the first file
3. Add a comment on one of the previously added line, publish
4. Reload the page, the expanding section is now collapsed
5. Expand the section again.  The comment is not visible.

In the example, the diffs have 3 files, so I put a comment on line 10 of
the second file.  The comment is visible only is you use the expand all

The issue is in diffviewer.js,  function addCommentFlags(table, lines)
        gHiddenComments = remaining;
addCommentFlags is called for each file, so gHiddenComments is overwritten
by the last file.

I'm testing a fix.

What is the expected output? What do you see instead?

What operating system are you using? What browser?

Please provide any additional information below.

You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to