Comment #2 on issue 1575 by philip.zeyliger: Show image files inline as part of diff view

The typical diff from git gives you something like:

diff --git a/docs/sdk/htmltable.png b/docs/sdk/htmltable.png
new file mode 100644
index 0000000..60617a2
Binary files /dev/null and b/docs/sdk/htmltable.png differ

Seems like there's enough there that reviewboard could ask git for the blob:

$git-cat-file blob 60617a2 > /tmp/z; file /tmp/z
/tmp/z: PNG image data, 813 x 142, 8-bit/color RGB, non-interlaced

I've noticed that reviewboard already does cat-file (our reviewboard server polls git every 5 minutes, and sometimes refuses to accept patches against versions that don't yet exist), so seems like it could do the same

Am I missing something?


You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to