Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1637 by dekun.chen.ivan: Review Board + perforce can not upload diff

hi, guys
 now i have setup one reviewboard server to review code changes for
perforce server, but i got the following error when i use cmd "post-review
3756" to create one review request

$ post-review 3756

Error uploading diff

The generated diff file was empty. This usually means no files were
modified in this change.

Try running with --output-diff and --debug for more information.

Your review request still exists, but the diff is not attached.

but i can found the changes with "post-review 3756 --output-diff --debug"
as the following description

$ post-review 3756 --output-diff --debug
svn info
git rev-parse --git-dir
p4 info
repository info: Path: p4_svr2:1666, Base path: None, Supports
changesets: T
Generating diff for changenum 3756
p4 describe -s 3756
Processing edit of
"//EMMI/branch/Email/proj/sc/product/xmmi_m800n/mak/options.mak#1" t
o "c:\docume~1\admini~1\locals~1\temp\tmpsx9vph"
p4 print -o c:\docume~1\admini~1\locals~1\temp\tmpsx9vph -q
diff -urNp c:\docume~1\admini~1\locals~1\temp\tmpsx9vph
--- //EMMI/branch/Email/proj/sc/product/xmmi_m800n/mak/options.mak
+++ //EMMI/branch/Email/proj/sc/product/xmmi_m800n/mak/options.mak
28 19:10:33
@@ -56,6 +56,13 @@ PP_OPT_COMMON+= __WAP__
 # Option_Selection= N/A

+# Feature_Name=EMAIL
+# Description=Option for EMAIL feature
+# Pre_Condition_On= N/A
+# Pre_Condition_Off= N/A
+# Option_Selection= N/A
 # Feature_Name=FAKE_VENDOR
 # Description=Option for a fake vendor to prevent frequent merging errors
 # Pre_Condition_On= N/A
@@ -776,6 +783,15 @@ ifeq ($(filter __MMS__ ,$(PP_OPT_COMMON)

+# Feature_Name=EMAIL
+# Description=Option to enable EMAIL function
+# Pre_Condition_On= __EMAIL__
+# Pre_Condition_Off= N/A
+# Option_Selection= N/A
+ifeq ($(filter __EMAIL__ ,$(PP_OPT_COMMON)),__EMAIL__)
 # Feature_Name=Disable SMS SIM Folder
 # Description=Option to disable the SMS SIM folder
 # Pre_Condition_On= N/A

any help for me???

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to