Updates:
Summary: Plain-text review request e-mails should use the full name in the signature Labels: -Priority-Medium -Milestone-Release1.5 Priority-Low Milestone-Release1.5.x


Comment #2 on issue 1502 by chipx86: Plain-text review request e-mails should use the full name in the signature
http://code.google.com/p/reviewboard/issues/detail?id=1502

There's really two things requested here. One is that we add the last name to the signature. The other is that we use the name from the Submit As, instead of the
Username. (Correct me if I'm wrong here.)

The former we can do, though honestly, from the From: and the "So and so wrote:" lines, I don't know that it's really that problematic and confusing. I'm tempted to
punt this one.

I don't see how the latter is a problem today. Maybe we've since fixed it? The code shows that we're using the submitter of the review request itself, which should always be right. We don't want to display any name other than the user who owns that
review request.

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to