Updates:
        Owner: chipx86
        Labels: -Component-SCMTools Component-DiffViewer Component-DiffParser

Comment #17 on issue 394 by chipx86: if a diff includes a file that has been cvs remove'd, reviewboard won't accept it
http://code.google.com/p/reviewboard/issues/detail?id=394

Been poking at this. Since the problem is that the RCS File line doesn't contain any information on which module the file is in, we may have to post-process the diff in post-review. Another option is to finally give Review Board a concept of "deleted files", but that's potentially a larger change.

This appears to be a conscious choice on behalf of cvs:

    /* This is fullname, not file, possibly despite the POSIX.2
     * specification, because that's the way all the Larry Wall
     * implementations of patch (are there other implementations?) want
     * things and the POSIX.2 spec appears to leave room for this.
     */

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to