Labels: Type-Defect Priority-Medium
New issue 1742 by earthling: Awkward workflow when reviewing code.
What version are you running?
What's the URL of the page containing the problem?
It starts by clicking the link in the review request.
What steps will reproduce the problem?
1. Click the link in the review request.
2. It's completely unapparent what you're supposed to do.
What is the expected output? What do you see instead?
I usually click the "review" button. But then you're taken to an overlay
that has a checkbox "ship it" and an unlabeled text area. Clicking the back
button doesn't work, so you have to go back to your email and click the
request link again or navigate there some other way.
Clicking the "view diff" button is actually what you want. When you do
that, the diff shows up, but then there's no obvious way to approve the
diff. A big "approve" or "diff" button that looks like a submit button
would really help. Instead, you have to click on a little tab in the upper
right that says "review."
What operating system are you using? What browser?
Please provide any additional information below.
One possible quick and dirty solution might be to go straight to the diff
from the email link. Then a prominent way to approve the diff would make
the whole process more obvious.
You received this message because you are subscribed to the Google Groups
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
For more options, visit this group at