Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium

New issue 1791 by josh.hamacher: Hide unreasonably large diffs.

*NOTE: If you have a patch, please submit it to

What version are you running?
1.5 RC 1

What's the URL of the page this enhancement relates to, if any?
The diff viewer.

Describe the enhancement and the motivation for it.
We have various tools that generate source code; sometimes these generated files are huge. Sometimes developers submit diffs of those generated files for code review. Sometimes those diffs are small enough that they actually get published (i.e. post-review doesn't time out) but still large enough to be virtually meaningless to a reviewer. We've added a very small change to diffviewer/ (see below) to hide these changes.

What operating system are you using? What browser?

Please provide any additional information below.
We've modified diffviewer/ as follows, starting at line 155:

    # treat gigantic diffs as binary
    maxDiffSizeK = 255
    diffSizeK = len( / 1024
    if (diffSizeK > maxDiffSizeK):
        f.binary = True = ""

We didn't submit this as a patch because there's probably a better way of doing it, but if it sounds reasonable we can do so.

You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to
To unsubscribe from this group, send email to
For more options, visit this group at

Reply via email to