Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 1800 by 12gaugemedia: Error uploading updated diff
http://code.google.com/p/reviewboard/issues/detail?id=1800
*NOTE: Do not post confidential information in this bug report.*
What version are you running?
1.5 RC1 (current Reviewboard.org version at reviews.reviewboard.org)
What's the URL of the page containing the problem?
http://reviews.reviewboard.org/r/1766/
What steps will reproduce the problem?
1. Change a file
2. Create a diff from Git with: git diff --full-index >> rev.diff
3. Create a review request from rev.diff
4. Commit the change with: git commit -a
5. Make another change to the file.
6. Create another diff from Git with: git diff --full-index >> rev2.diff
7. Update the diff on the review request with the new rev2.diff
8. Error:
Environment: Request Method: POST Request URL:
http://reviews.reviewboard.org/api/json/reviewrequests/1766/diff/new/
Django Version: 1.2.1 Python Version: 2.5.2 Installed Applications:
['django.contrib.admin', 'django.contrib.auth', 'django.contrib.contenttypes', 'django.contrib.markup', 'django.contrib.sites', 'django.contrib.sessions', 'djblets.datagrid', 'djblets.feedview', 'djblets.log', 'djblets.siteconfig', 'djblets.util', 'djblets.webapi', 'reviewboard.accounts', 'reviewboard.admin', 'reviewboard.changedescs', 'reviewboard.diffviewer', 'reviewboard.iphone', 'reviewboard.notifications', 'reviewboard.reports', 'reviewboard.reviews', 'reviewboard.scmtools', 'reviewboard.webapi', 'django_evolution']
Installed Middleware:
('django.middleware.gzip.GZipMiddleware', 'django.middleware.common.CommonMiddleware', 'django.middleware.doc.XViewMiddleware', 'django.middleware.http.ConditionalGetMiddleware', 'django.middleware.locale.LocaleMiddleware', 'django.contrib.sessions.middleware.SessionMiddleware', 'django.contrib.auth.middleware.AuthenticationMiddleware', 'djblets.siteconfig.middleware.SettingsMiddleware', 'reviewboard.admin.middleware.LoadSettingsMiddleware', 'djblets.log.middleware.LoggingMiddleware', 'reviewboard.admin.middleware.CheckUpdatesRequiredMiddleware', 'reviewboard.admin.middleware.X509AuthMiddleware')
Traceback:
File "/usr/lib/python2.5/site-packages/Django-1.2.1-py2.5.egg/django/core/handlers/base.py"
in get_response 100. response = callback(request, *callback_args,
**callback_kwargs)
File "/usr/lib/python2.5/site-packages/Django-1.2.1-py2.5.egg/django/views/decorators/cache.py"
in _wrapped_view_func 70. add_never_cache_headers(response)
File "/usr/lib/python2.5/site-packages/Django-1.2.1-py2.5.egg/django/utils/cache.py"
in add_never_cache_headers 116. patch_response_headers(response,
cache_timeout=-1)
File "/usr/lib/python2.5/site-packages/Django-1.2.1-py2.5.egg/django/utils/cache.py"
in patch_response_headers 105. response['ETag'] = '"%s"' %
md5_constructor(response.content).hexdigest()
File "/usr/lib/python2.5/site-packages/Djblets-0.6.4alpha0.dev_20100830-py2.5.egg/djblets/webapi/core.py"
in _get_content 270. content = adapter.encode(self.api_data,
request=self.request)
File "/usr/lib/python2.5/site-packages/Djblets-0.6.4alpha0.dev_20100830-py2.5.egg/djblets/webapi/core.py"
in encode 119. self.__encode(o, *args, **kwargs)
File "/usr/lib/python2.5/site-packages/Djblets-0.6.4alpha0.dev_20100830-py2.5.egg/djblets/webapi/core.py"
in __encode 136. self.__encode(value, *args, **kwargs)
File "/usr/lib/python2.5/site-packages/Djblets-0.6.4alpha0.dev_20100830-py2.5.egg/djblets/webapi/core.py"
in __encode 162. raise TypeError("%r is not XML serializable" % (o,))
Exception Type: TypeError at /api/json/reviewrequests/1766/diff/new/
Exception Value: 1877L is not XML serializable
What is the expected output? What do you see instead?
Should update the review with the newly submit diff
What operating system are you using? What browser?
Windows 7, Chrome 5
Please provide any additional information below.
Tried applying the diff as a delta from the first change, and as a delta
from the original version, same error. Tried including the original diff
as the parent diff, same error.
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
