Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1801 by karen.ga...@gmail.com: The Reviewboard 1.0.9 chokes on a diff of a Visual Studio .vcproj project file
http://code.google.com/p/reviewboard/issues/detail?id=1801

Reviewboard fails parsing a diff of a .vcproj project file in my Visual Studio solution.

The patch file causing the problem is attached to the issue, and there is no problem with it.

But here is the error that I see when patch is uploaded to Reviewboard 1.0.9:

---------------------------------------------------------------------------

The patch to 'security-alert-service/security-alert-service.vcproj' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.H89VPH' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.H89VPH/tmp22U1xl patch: **** malformed patch at line 17: )\Settings.lib $(OutDir)\Subscriber.lib $(OutDir)\ScriptHandlerLib.lib ..\..\..\shared-libs\CrossPlatform\lib3rd\bin\win32\boost\v1.38\libboost_system-vc80-mt-sgd-1_38.lib $(OutDir)\SoftwareManagement.lib $(OutDir)\FulfillmentInService.lib ..\..\..\shared-libs\CrossPlatform\lib3rd\bin\win32\debug\curllib-vc80-mt-sgd-7_19_6.lib ..\..\..\shared-libs\CrossPlatform\lib3rd\bin\win32\debug\curlpp-vc80-mt-sgd-0_7_3.lib $(OutDir)\Migration.lib $(OutDir)\StorageManagement.lib ..\..\..\shared-libs\CrossPlatform\lib3rd\bin\win32\Debug_Unicode\json_spirit-vc80-mt-sgd-4_0_2.lib"

Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/ReviewBoard-1.0.9-py2.6.egg/reviewboard/diffviewer/views.py", line 153, in view_diff
    interdiffset, highlighting, True)
File "/usr/lib/python2.6/site-packages/ReviewBoard-1.0.9-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 624, in get_diff_files
    large_data=True)
File "/usr/lib/python2.6/site-packages/Djblets-0.6.3-py2.6.egg/djblets/util/misc.py", line 166, in cache_memoize
    data = lookup_callable()
File "/usr/lib/python2.6/site-packages/ReviewBoard-1.0.9-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 623, in <lambda>
    enable_syntax_highlighting),
File "/usr/lib/python2.6/site-packages/ReviewBoard-1.0.9-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 346, in get_chunks
    new = get_patched_file(old, filediff)
File "/usr/lib/python2.6/site-packages/ReviewBoard-1.0.9-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 261, in get_patched_file
    return patch(filediff.diff, buffer, filediff.dest_file)
File "/usr/lib/python2.6/site-packages/ReviewBoard-1.0.9-py2.6.egg/reviewboard/diffviewer/diffutils.py", line 129, in patch
    (filename, tempdir, patch_output))
Exception: The patch to 'security-alert-service/security-alert-service.vcproj' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.H89VPH' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.H89VPH/tmp22U1xl
patch: **** malformed patch at line 17: )\Settings.lib $(OutDir)\Subscriber.lib $(OutDir)\ScriptHandlerLib.lib ..\..\..\shared-libs\CrossPlatform\lib3rd\bin\win32\boost\v1.38\libboost_system-vc80-mt-sgd-1_38.lib $(OutDir)\SoftwareManagement.lib $(OutDir)\FulfillmentInService.lib ..\..\..\shared-libs\CrossPlatform\lib3rd\bin\win32\debug\curllib-vc80-mt-sgd-7_19_6.lib ..\..\..\shared-libs\CrossPlatform\lib3rd\bin\win32\debug\curlpp-vc80-mt-sgd-0_7_3.lib $(OutDir)\Migration.lib $(OutDir)\StorageManagement.lib ..\..\..\shared-libs\CrossPlatform\lib3rd\bin\win32\Debug_Unicode\json_spirit-vc80-mt-sgd-4_0_2.lib"


Attachments:
        DiffOfVcprojFileThatChockesReviewBoard.patch  2.5 KB

--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to