Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 1808 by AaronJSherman: RBTools 0.2 perforce: no error handling for bad change #
http://code.google.com/p/reviewboard/issues/detail?id=1808

*NOTE: Do not post confidential information in this bug report.*

What version are you running?

RBTools 0.2

What's the URL of the page containing the problem?

N/A

What steps will reproduce the problem?
1. post-review x (where x > current highest changeset #)
2.
3.

What is the expected output? What do you see instead?

I would expect an error indicating that I've used a bad changeset #

What operating system are you using? What browser?

I get this traceback:

Traceback (most recent call last):
  File "/build/trees/bin/reviewboard/post-review", line 2879, in <module>
    main()
  File "/build/trees/bin/reviewboard/post-review", line 2847, in main
    diff, parent_diff = tool.diff(args)
  File "/build/trees/bin/reviewboard/post-review", line 1481, in diff
    return self._changenum_diff(changenum)
File "/build/trees/bin/reviewboard/post-review", line 1679, in _changenum_diff
    if '*pending*' in description[0] or '*pending*' in description[1]:

Please provide any additional information below.

This is not new. Previous versions simply spat out this relatively useless error instead of a stack trace:

Couldn't find any affected files for this change.

Where the actual p4 describe output that post-review is getting says:

226188 - no such changelist.

I'd suggest that "no such changelist" be searched for in the first line of output BEFORE trying to do any other results searching.



--
You received this message because you are subscribed to the Google Groups 
"reviewboard-issues" group.
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
reviewboard-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/reviewboard-issues?hl=en.

Reply via email to