Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
New issue 1847 by dekrueg: The diff-comments resource is unaccessible in
REST API 2.0
http://code.google.com/p/reviewboard/issues/detail?id=1847
What version are you running?
1.5
What's the URL of the page containing the problem?
/api/review-requests/{review_request_id}/reviews/{review_id}/diff-comments/
What steps will reproduce the problem?
1. Attempt a GET of a diff-comments resource URL in the REST API
What is the expected output? What do you see instead?
Expect return of JSON resource. G
et a 500 status code and the following traceback:
---------------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/core/handlers/base.py",
line 92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File "/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/views/decorators/cache.py",
line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File "/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/views/decorators/vary.py",
line 21, in inner_func
response = func(*args, **kwargs)
File "/usr/lib/python2.5/site-packages/Djblets-0.6.5alpha0.dev_20101008-py2.5.egg/djblets/webapi/resources.py",
line 284, in __call__
result = view(request, api_format=api_format, *args, **kwargs)
File "/usr/lib/python2.5/site-packages/Djblets-0.6.5alpha0.dev_20101008-py2.5.egg/djblets/util/decorators.py",
line 74, in _call
f = real_func(*args, **kwargs)
File "/usr/lib/python2.5/site-packages/ReviewBoard-1.5-py2.5.egg/reviewboard/webapi/decorators.py",
line 25, in _check
return view_func(*args, **kwargs)
File "/usr/lib/python2.5/site-packages/Djblets-0.6.5alpha0.dev_20101008-py2.5.egg/djblets/webapi/decorators.py",
line 233, in _validate
return view_func(*args, **new_kwargs)
File "/usr/lib/python2.5/site-packages/ReviewBoard-1.5-py2.5.egg/reviewboard/webapi/resources.py",
line 103, in get_list
return self._get_list_impl(request, *args, **kwargs)
File "/usr/lib/python2.5/site-packages/ReviewBoard-1.5-py2.5.egg/reviewboard/webapi/resources.py",
line 112, in _get_list_impl
return super(WebAPIResource, self).get_list(request, *args, **kwargs)
File "/usr/lib/python2.5/site-packages/Djblets-0.6.5alpha0.dev_20101008-py2.5.egg/djblets/webapi/decorators.py",
line 233, in _validate
return view_func(*args, **new_kwargs)
File "/usr/lib/python2.5/site-packages/Djblets-0.6.5alpha0.dev_20101008-py2.5.egg/djblets/webapi/resources.py",
line 469, in get_list
extra_data=data)
File "/usr/lib/python2.5/site-packages/Djblets-0.6.5alpha0.dev_20101008-py2.5.egg/djblets/webapi/core.py",
line 322, in __init__
results = list(results)
File "/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/db/models/query.py",
line 83, in __len__
self._result_cache.extend(list(self._iter))
File "/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/db/models/query.py",
line 238, in iterator
for row in self.query.results_iter():
File "/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/db/models/sql/query.py",
line 287, in results_iter
for rows in self.execute_sql(MULTI):
File "/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/db/models/sql/query.py",
line 2369, in execute_sql
cursor.execute(sql, params)
File "/usr/lib/python2.5/site-packages/Django-1.1.1-py2.5.egg/django/db/backends/sqlite3/base.py",
line 193, in execute
return Database.Cursor.execute(self, query, params)
InterfaceError: Error binding parameter 1 - probably unsupported type.
<ModPythonRequest
path:/api/review-requests/477/reviews/1282/diff-comments/,
GET:<QueryDict: {}>,
POST:<QueryDict: {}>,
COOKIES:{},
META:{'AUTH_TYPE': None,
'CONTENT_LENGTH': 0,
'CONTENT_TYPE': None,
'GATEWAY_INTERFACE': 'CGI/1.1',
'HTTP_HOST': 'review.example.com',
'HTTP_USER_AGENT': 'Python-urllib/1.17',
'PATH_INFO': u'/api/review-requests/477/reviews/1282/diff-comments/',
'PATH_TRANSLATED': None,
'QUERY_STRING': None,
'REMOTE_ADDR': '172.16.71.82',
'REMOTE_HOST': None,
'REMOTE_IDENT': None,
'REMOTE_USER': None,
'REQUEST_METHOD': 'GET',
'SCRIPT_NAME': '',
'SERVER_NAME': 'review.example.com',
'SERVER_PORT': 80,
'SERVER_PROTOCOL': 'HTTP/1.0',
'SERVER_SOFTWARE': 'mod_python'}>
---------------------------------------------------------------------------
What operating system are you using? What browser?
Fedora
No browser (a Python application)
--
You received this message because you are subscribed to the Google Groups
"reviewboard-issues" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/reviewboard-issues?hl=en.
