Comment #5 on issue 929 by d...@n-cube.org: reviewboard should not alter
the diff file
I wonder if this wouldn't still be a good idea. I was trying to review
http://reviews.reviewboard.org/r/1737/ the other day because I thought it
might address this problem, at least for git. However, besides missing the
mail headers from format-patch, it was also missing the new file mode
lines, so even once I had an appropriate base to apply on, I had to
manually edit the diff just to get it to apply.
I suspect there's always going to be the risk of losing portions of a diff
if you break up and process it and then try to recreate it. Saving a
pristine 'patch' alongside the reviewboard internal diff segments might
actually be a more robust approach.
Whatever we do, we really need to do something. I was hoping Eduardo's
patch would do this, but it definitely had some bugs in it and I'm a bit
confused over the 'bundle' concept he introduced since a format-patch
output is only a single patch...
You received this message because you are subscribed to the Google Groups
To post to this group, send email to reviewboard-iss...@googlegroups.com.
To unsubscribe from this group, send email to
For more options, visit this group at